Skip to content

[PM-34491] Address Targeting Rules implementation gaps#21364

Draft
jprusik wants to merge 3 commits into
mainfrom
pm-34491-refactor
Draft

[PM-34491] Address Targeting Rules implementation gaps#21364
jprusik wants to merge 3 commits into
mainfrom
pm-34491-refactor

Conversation

@jprusik

@jprusik jprusik commented Jun 18, 2026

Copy link
Copy Markdown
Contributor

🎟️ Tracking

PM-34491

📔 Objective

📸 Screenshots

@codecov

codecov Bot commented Jun 18, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 85.50725% with 10 lines in your changes missing coverage. Please review.
✅ Project coverage is 49.23%. Comparing base (47e9111) to head (8618154).
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...ofill/services/collect-autofill-content.service.ts 89.65% 1 Missing and 5 partials ⚠️
...ofill/services/autofill-overlay-content.service.ts 50.00% 3 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #21364      +/-   ##
==========================================
+ Coverage   49.22%   49.23%   +0.01%     
==========================================
  Files        4074     4074              
  Lines      127790   127826      +36     
  Branches    19549    19564      +15     
==========================================
+ Hits        62908    62941      +33     
  Misses      60233    60233              
- Partials     4649     4652       +3     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jprusik jprusik changed the title [PM-34491] [PM-34491] Address Targeting Rules implementation gaps Jun 18, 2026
@jprusik jprusik force-pushed the pm-34491-refactor branch from fd0cb12 to 8618154 Compare June 22, 2026 14:32
@sonarqubecloud

Copy link
Copy Markdown

@bw-ghapp

bw-ghapp Bot commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

Changes in this PR impact the Autofill experience of the browser client

BIT has tested the core experience with these changes and the feature flag configuration used by vault.bitwarden.com.

✅ Fortunately, these BIT tests have passed! 🎉

@bw-ghapp

bw-ghapp Bot commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

Changes in this PR impact the Autofill experience of the browser client

BIT has tested the core experience with these changes and all feature flags disabled.

✅ Fortunately, these BIT tests have passed! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant